proto: allow shell vars to propagate to protoc.#779
proto: allow shell vars to propagate to protoc.#779htuch wants to merge 1 commit intobazel-contrib:masterfrom
Conversation
Similar to protocolbuffers/protobuf#2508, when using protoc with non-standard LD_LIBRARY_PATH, we need to be able to have it pick up from the environment the correct LD_LIBRARY_PATH.
|
Can one of the admins verify this patch? |
|
I think that use_default_shell_env is fundamentally incompatible with remote execution, this is probably not the right way to solve the problem. |
|
It's built under Bazel using a C++ toolchain configured with CC/CXX/LD_LIBRARY_PATH. Other host binaries are built with whatever the host base image is using. FWIW, we're building on Goobuntu with CXX/LD_LIBRARY_PATH pointing at crosstools. Would anyone want to remotely execute this rule when building with a custom local toolchain? |
|
Closing this out based on offline discussion with @ianthehat. We have a bunch of needs (this PR, arbitrary plugins) that don't match well with the current |
…es (bazel-contrib#779) Update Python minor toolchain versions to allow smaller Python toolchains Co-authored-by: Matt Mackay <mattem@gmail.com>
4 participants
Similar to protocolbuffers/protobuf#2508, when using
protoc with non-standard LD_LIBRARY_PATH, we need to be able to have it
pick up from the environment the correct LD_LIBRARY_PATH.